Fix bug when gradle clean spotlessCheck was called on parallel build
#501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbduncan
reviewed
Jan 1, 2020
| // actually happen (as desired) | ||
| // | ||
| // we use System.identityHashCode() to avoid a memory leak by hanging on to the reference directly | ||
| SpotlessCache.clearOnce(System.identityHashCode(project.getRootProject())); |
There was a problem hiding this comment.
@nedtwigg Reading the source code for SpotlessCache::clearOnce, I'm unclear on why passing project.getRootProject() to the method would cause the method to hang onto it; AFAICT the method never stores the reference inside a field or something similar. 🤔
So I was wondering if you could help me understand why the call to System::identityHashCode is needed here?
There was a problem hiding this comment.
There was a problem hiding this comment.
This might be a better way to spell it, but I think the javadoc is the clearest explanation.
if (key == null || !key.equals(lastClear)) {
lastClear = key;
} else {
// only clear once
return false;
}There was a problem hiding this comment.
Aha, that lastClear = key line is what I'd missed! Thank you @nedtwigg. :)
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243